[PATCH] D113644: [NFC][InlineAdvisor] Inform advisor when the module is invalidated

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 11 09:37:10 PST 2021


aeubanks added a comment.

It looks like the expensive part is recalculating `FunctionPropertiesAnalysis` in `getLocalCalls()`. Since you're only using `DirectCallsToDefinedFunctions`, could you implement that yourself rather than relying on the potentially expensive `FunctionPropertiesAnalysis`? For example, it looks like it needs to construct all the loops in the function which could be expensive.
Counting by hand the number of direct calls should be quick and unnoticeable in terms of compile time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113644/new/

https://reviews.llvm.org/D113644



More information about the llvm-commits mailing list