[PATCH] D113573: Add a (nonfunctional) -dyld_info flag to llvm-objdump.

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 11 09:18:38 PST 2021


aprantl added a comment.

> What's the motivation for adding the option without implementation at this point?

This patch is part of a series of patches to upstream chained fixup support in MachOObjectFile and I need an implementation of -dyld_info to write tests for that feature. I'm trying break the patch into small pieces to make reviewing easier. With every patch the implementation will become more complete.



================
Comment at: llvm/tools/llvm-objdump/MachODump.cpp:1183-1185
+//===----------------------------------------------------------------------===//
+// chained fixup table dumping
+//===----------------------------------------------------------------------===//
----------------
jhenderson wrote:
> I don't think we usually bother with these sorts of comments? NB: I haven't bothered looking at the context, so there may be precedent in this file for it.
You're right, the rest of the file also doesn't use them.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113573/new/

https://reviews.llvm.org/D113573



More information about the llvm-commits mailing list