[PATCH] D113573: Add a (nonfunctional) -dyld_info flag to llvm-objdump.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Please remember to add new options to the .rst file for llvm-otool.

What's the motivation for adding the option without implementation at this point?



================
Comment at: llvm/test/tools/llvm-objdump/MachO/dyld_info.test:2
+# RUN: llvm-objdump --macho --dyld_info %p/Inputs/bind.macho-x86_64 \
+# RUN:   | FileCheck %s --match-full-lines --strict-whitespace
+
----------------
Probably want to add `--implicit-check-not={{.}}` to catch any new/additional output too.

I have a slight personal preference for putting the `|` at the end of the continued line, to indicate that the next line will be the start of a new command entirely, but I'm not fussed either way.


================
Comment at: llvm/tools/llvm-objdump/MachODump.cpp:1183-1185
+//===----------------------------------------------------------------------===//
+// chained fixup table dumping
+//===----------------------------------------------------------------------===//
----------------
I don't think we usually bother with these sorts of comments? NB: I haven't bothered looking at the context, so there may be precedent in this file for it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113573/new/

https://reviews.llvm.org/D113573