[PATCH] D113395: [flang][CodeGen] Transform `IsPresentOpConversion` and `AbsentOpConversion`

[Eric Schweitz via Phabricator via llvm-commits]

schweitz added inline comments.


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:579
+    pattern
+        .insert<AbsentOpConversion, AddrOfOpConversion, CallOpConversion,
+                ExtractValueOpConversion, HasValueOpConversion,
----------------
clementval wrote:
> awarzynski wrote:
> > schweitz wrote:
> > > Different version of clang-format?
> > Not necessarily. IIRC, clang-format has no hard rules for where to break lines. But I couldn't find a definitive answer. 
> > 
> > I use clang-format-13. Pre-commit CI seems happy. Shall we leave it like this?
> Looks fine now. 
Looks like the random whitespace changes disappeared. Good.

Andrzej, we've found that using even slightly different builds of clang-format cause mysterious whitespace changes. It's not about any rule. It just happens.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113395/new/

https://reviews.llvm.org/D113395