[PATCH] D113395: [flang][CodeGen] Transform `IsPresentOpConversion` and `AbsentOpConversion`

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 10 00:21:38 PST 2021


clementval accepted this revision.
clementval added a comment.

LGTM



================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:579
+    pattern
+        .insert<AbsentOpConversion, AddrOfOpConversion, CallOpConversion,
+                ExtractValueOpConversion, HasValueOpConversion,
----------------
awarzynski wrote:
> schweitz wrote:
> > Different version of clang-format?
> Not necessarily. IIRC, clang-format has no hard rules for where to break lines. But I couldn't find a definitive answer. 
> 
> I use clang-format-13. Pre-commit CI seems happy. Shall we leave it like this?
Looks fine now. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113395/new/

https://reviews.llvm.org/D113395



More information about the llvm-commits mailing list