[PATCH] D113528: [RISCV] Fix non-sensical intrinsic names in rv64i-single-softfloat.ll. NFC

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 11 08:33:16 PST 2021


craig.topper added a comment.

In D113528#3124171 <https://reviews.llvm.org/D113528#3124171>, @luismarques wrote:

> LGTM.
>
> In D113528#3120204 <https://reviews.llvm.org/D113528#3120204>, @jrtc27 wrote:
>
>> I don't know why there aren't just RVxxI versions in the {float,double}-intrinsics.ll files; this seems like unnecessary duplication of effort, is under-tested due to not having any RV32I tests and rv64i-double-softfloat.ll is comparatively minimal.
>
> @craig.topper Is this something you'd be interested in addressing in a revised version of this patch or in a follow-up patch?

I'll work on it in a follow-up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113528/new/

https://reviews.llvm.org/D113528



More information about the llvm-commits mailing list