[PATCH] D113528: [RISCV] Fix non-sensical intrinsic names in rv64i-single-softfloat.ll. NFC

Luís Marques via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 11 03:54:21 PST 2021


luismarques accepted this revision.
luismarques added a comment.
This revision is now accepted and ready to land.

LGTM.

In D113528#3120204 <https://reviews.llvm.org/D113528#3120204>, @jrtc27 wrote:

> I don't know why there aren't just RVxxI versions in the {float,double}-intrinsics.ll files; this seems like unnecessary duplication of effort, is under-tested due to not having any RV32I tests and rv64i-double-softfloat.ll is comparatively minimal.

@craig.topper Is this something you'd be interested in addressing in a revised version of this patch or in a follow-up patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113528/new/

https://reviews.llvm.org/D113528



More information about the llvm-commits mailing list