[PATCH] D113629: Add path to lower addrspacecasts in constant exprs for __ptr32/__ptr64.

[John Reagan via Phabricator via llvm-commits]

JohnReagan added inline comments.


================
Comment at: llvm/lib/Target/X86/X86AsmPrinter.cpp:138
+  if ((SrcAS == 0 || SrcAS == X86AS::PTR32_UPTR) && DstAS == X86AS::PTR64) {
+    // For zero extension, emit a zero constant. This doesn't handle cases when
+    // sign extension is specified.
----------------
What would the sign-extended form look like?  Is it much harder to add? I thought I remember you have both signed and zero extended in other places?  (I'm biased since OpenVMS wants sign-extended behavior)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113629/new/

https://reviews.llvm.org/D113629