[PATCH] D113629: Add path to lower addrspacecasts in constant exprs for __ptr32/__ptr64.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 10 16:51:33 PST 2021


arsenm added inline comments.


================
Comment at: llvm/lib/Target/X86/X86AsmPrinter.cpp:145
+    // For trunc, just remove the addrspacecast.
+    AsmPrinter::emitGlobalConstant(DL, Op);
+  } else {
----------------
Would it be easier to just add a new callback to handle addrspacecast instead of having to reproduce some of the generic logic and call into the default implementation


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113629/new/

https://reviews.llvm.org/D113629



More information about the llvm-commits mailing list