[PATCH] D113541: [lld-macho] Fix trailing slash in oso_prefix

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/MachO/Driver.cpp:1162
         expanded += sep;
+      else if (config->osoPrefix.endswith(sep) && !expanded.endswith(sep))
+        expanded += sep;
----------------
oontvoo wrote:
> keith wrote:
> > Maybe the second half of the conditional here isn't necessary?
> I guess it's not needed if we can count on real_path to NOT change its behaviour.
> But the tests below should catch it.
Given that realpath is a POSIX API with very wide use, I think it is extremely unlikely to ever change its behavior...

I guess this means we can remove the check on line 1160 too


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113541/new/

https://reviews.llvm.org/D113541