[PATCH] D113541: [lld-macho] Fix trailing slash in oso_prefix

Vy Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 10 07:12:37 PST 2021


oontvoo accepted this revision.
oontvoo added a comment.
This revision is now accepted and ready to land.

LG Thanks!



================
Comment at: lld/MachO/Driver.cpp:1162
         expanded += sep;
+      else if (config->osoPrefix.endswith(sep) && !expanded.endswith(sep))
+        expanded += sep;
----------------
keith wrote:
> Maybe the second half of the conditional here isn't necessary?
I guess it's not needed if we can count on real_path to NOT change its behaviour.
But the tests below should catch it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113541/new/

https://reviews.llvm.org/D113541



More information about the llvm-commits mailing list