[PATCH] D113475: [llvm-tblgen][RISCV] Make llvm-tblgen RISCVCompressInstEmitter to be common infra across different targets

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/utils/TableGen/CompressInstEmitter.cpp:419
+  Record *Operator = SourceDag->getOperatorAsDef(Rec->getLoc());
+  if (!Operator->isSubClassOf("Inst32"))
+    PrintFatalError(Rec->getLoc(), "Input instruction '" + Operator->getName() +
----------------
Are these errors the only reasons we need the Inst32 and Inst16 classes to be introduced in Target.td? Can we check the size relationships instead? If we're making this generic it doesn't seem like we should be hardcoding 16 and 32.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113475/new/

https://reviews.llvm.org/D113475