[PATCH] D113035: [InstCombine] enhance vector bitwise select matching
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 8 12:16:22 PST 2021
spatel added a subscriber: dmgreen.
spatel added inline comments.
================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp:2372
+ Type *SelTy = A->getType();
+ if (auto *VecTy = dyn_cast<FixedVectorType>(Cond->getType())) {
+ unsigned Elts = VecTy->getNumElements();
----------------
lebedev.ri wrote:
> What happens for scalable vectors? I'm not seeing any check against that.
I couldn't come up with a way to get in here with a scalable vector because of the 'not' instruction requirement. But let me know if you see a way to do that (ping @dmgreen too).
I can add an assert for scalable vector type if I got that right.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113035/new/
https://reviews.llvm.org/D113035
More information about the llvm-commits
mailing list