[PATCH] D113241: [lld-macho][nfc] rename parsed-section types & variables
Jez Ng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 8 10:42:20 PST 2021
int3 added a comment.
> That sounds like mitigated speech for "veto". Correct me if I misinterpret.
It's vote, not veto ;)
Yeah the s/subsections/sections/ and s/subsecMap/subsections/ thing looks reasonable. +1 to Vy's opinion that types should ideally be left out of the name anyway; let's drop both the Map and Vec.
I agree with Vincent's opinion that `Section` -> `SectionHeader` breaks consistency with the other MachOStructs.h types. The convention I was going for was to have all non-serialized section/segment types be prefixed by "Input" or "Output". But I don't feel super strongly about this, so if you prefer SectionHeader, go for it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113241/new/
https://reviews.llvm.org/D113241
More information about the llvm-commits
mailing list