[PATCH] D113295: [flang] Transform `fir.end` to an empty statement

[Andrzej Warzynski via Phabricator via llvm-commits]

awarzynski added a comment.

@mehdi_amini , these are much appreciated pointers, thank you!



================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:92
+  }
+};
+
----------------
mehdi_amini wrote:
> mehdi_amini wrote:
> > I was wondering if we need a pattern of its own for this op or if this should be handled by the parent operation?
> > 
> > The test shows it in isolation, but that does not exist, does it?
> I even wonder if the verifier for `fir.end` shouldn't check on the actual parent op and limit it to be nested in some specific ones.
I think that would make more sense. But, IIUC, in the current design there's only one such parent and it's only going to be needed for F2003. We are still working towards F95, so this is not required yet. 

Perhaps we should just postpone this one until it's really needed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113295/new/

https://reviews.llvm.org/D113295