[PATCH] D113295: [flang] Transform `fir.end` to an empty statement

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 8 10:08:37 PST 2021


mehdi_amini added inline comments.


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:92
+  }
+};
+
----------------
mehdi_amini wrote:
> I was wondering if we need a pattern of its own for this op or if this should be handled by the parent operation?
> 
> The test shows it in isolation, but that does not exist, does it?
I even wonder if the verifier for `fir.end` shouldn't check on the actual parent op and limit it to be nested in some specific ones.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113295/new/

https://reviews.llvm.org/D113295



More information about the llvm-commits mailing list