[PATCH] D88741: [SystemZ/z/OS] Add utility class for char set conversion.

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added a comment.

@Kai, I've completed my review of the current state of this patch. I am out-of-office for three weeks. I hope my comments are clear enough to address and for other reviewers to confirm action/response on.



================
Comment at: llvm/unittests/Support/CharSetTest.cpp:191
+
+} // namespace
----------------
hubert.reinterpretcast wrote:
> There is no representation in the testing of stateful encodings.
> 
> Reasonable tests (separately for ISO-2022-JP and IBM-939) include:
> 
>   - "Returning to the initial shift state" when in the initial shift state generates an empty output sequence.
>   - "Returning to the initial shift state" after the previous conversion ended with a character that requires a shift from the initial shift state generates a non-empty output sequence.
> 
I suggest trying to write these tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88741/new/

https://reviews.llvm.org/D88741