[PATCH] D88741: [SystemZ/z/OS] Add utility class for char set conversion.

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/include/llvm/Support/CharSet.h:102
+
+  /// Converts a string.
+  /// \param[in] Source source string
----------------
I think "string" is too ambiguous. Additional sentences to clarify would help:
Converts the contents of a StringRef, which conventionally does not include a terminating null character. No additional null termination of the result is attempted.


================
Comment at: llvm/include/llvm/Support/CharSet.h:127
+
+  /// Converts a string.
+  /// \param[in] Source source string
----------------
Can refer to the other function to note clarifications re: null termination.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88741/new/

https://reviews.llvm.org/D88741