[PATCH] D113178: [PowerPC] use right register class for input operand of XXPERMDIs

Jinsong Ji via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 5 06:51:11 PDT 2021


jsji added a comment.

> Of course the distinction is purely aesthetic, but I think it helps readability.

Yes, this help readability when there are large number of instructions between lfiwax and xxspltd.
But this does introduce confusion about register classes -- it is suspicious that `xxspltd` operate on `f0` instead of `vs0`.

I am OK with leaving it as it is, but I think we should at least add some comments in `XXPERMDIs` to clarify this register class change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113178/new/

https://reviews.llvm.org/D113178



More information about the llvm-commits mailing list