[PATCH] D113214: [IR][ShuffleVector] Introduce `isReplicationMask()` matcher

Fri Nov 5 06:36:53 PDT 2021

lebedev.ri added a comment.

In D113214#3111532 <https://reviews.llvm.org/D113214#3111532>, @spatel wrote:

> In D113214#3111487 <https://reviews.llvm.org/D113214#3111487>, @lebedev.ri wrote:
>
>> In D113214#3111481 <https://reviews.llvm.org/D113214#3111481>, @spatel wrote:
>>
>>> LGTM
>>
>> Thank you for the review!
>>
>>> I don't have any experience with the test generator (so might want to wait on a 2nd opinion), but the code looks right.
>>
>> Which test generator, `CombinationGenerator`?
>
> Yes - I see that it's coming from exegesis, but I'm not familiar with that code.

Ah, that's fine, i convinced the original author <https://reviews.llvm.org/D74156> to write these new tests.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113214/new/

https://reviews.llvm.org/D113214