[PATCH] D113214: [IR][ShuffleVector] Introduce `isReplicationMask()` matcher

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 5 06:21:39 PDT 2021


spatel added a comment.

In D113214#3111487 <https://reviews.llvm.org/D113214#3111487>, @lebedev.ri wrote:

> In D113214#3111481 <https://reviews.llvm.org/D113214#3111481>, @spatel wrote:
>
>> LGTM
>
> Thank you for the review!
>
>> I don't have any experience with the test generator (so might want to wait on a 2nd opinion), but the code looks right.
>
> Which test generator, `CombinationGenerator`?

Yes - I see that it's coming from exegesis, but I'm not familiar with that code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113214/new/

https://reviews.llvm.org/D113214



More information about the llvm-commits mailing list