[PATCH] D113235: [lld-macho] Replace LC_LINKER_OPTION parsing

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/MachO/Driver.cpp:412-413
+    StringRef arg = argv[i];
+    if (arg.startswith("-l")) {
+      StringRef name = arg.drop_front(2);
       ForceLoad forceLoadArchive =
----------------



================
Comment at: lld/MachO/Driver.cpp:419
                  /*isReexport=*/false, /*isExplicit=*/false, forceLoadArchive);
       break;
     }
----------------
wait a minute... shouldn't this be `continue`, or the next line changed to `else if`?

I'd thought we would have tests to catch this :/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113235/new/

https://reviews.llvm.org/D113235