[PATCH] D113235: [lld-macho] Replace LC_LINKER_OPTION parsing

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 4 21:28:52 PDT 2021


int3 accepted this revision.
int3 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/MachO/Driver.cpp:399
 // Parses LC_LINKER_OPTION contents, which can add additional command line
 // flags.
 void macho::parseLCLinkerOption(InputFile *f, unsigned argc, StringRef data) {
----------------
Can we include in the comment an explanation of why we're not using OptTable? Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113235/new/

https://reviews.llvm.org/D113235



More information about the llvm-commits mailing list