[PATCH] D112977: [lld-macho] Fix failed assertion in registerCompactUnwind

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 4 07:46:57 PDT 2021


int3 added a comment.

Hmm I think you missed my earlier comment about the test:

> We can probably just extend weak-definition-gc.s instead of creating a new test. And we should verify that the associated contents are indeed deleted.



> IMO once we cover that case, I don't think it's particularly important to test that the assert in registerCompactUnwind isn't fired. The "coalesced symbol => coalesced section contents" invariant is the more fundamental thing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112977/new/

https://reviews.llvm.org/D112977



More information about the llvm-commits mailing list