[PATCH] D112977: [lld-macho] Fix failed assertion in registerCompactUnwind

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 4 07:46:39 PDT 2021


thakis added inline comments.


================
Comment at: lld/MachO/SymbolTable.cpp:69
+        // ...). We could imitate it in the future but for now, this seems to
+        // wor,.
         if (defined->isWeakDef()) {
----------------
There's a long comment about this in createDefined() in InputFiles.cpp. Maybe refer to that instead.

(Also, typo `,.`)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112977/new/

https://reviews.llvm.org/D112977



More information about the llvm-commits mailing list