[PATCH] D113142: [CodeView] Properly handle a DISubprogram in getScopeIndex.

[Chih-Ping Chen via Phabricator via llvm-commits]

cchen15 added a comment.

Thanks for the feedback, Reid!

Here's the linker error I am seeing with VS2019 16.11.2 before this patch is applied:

  [cchen15 at f90srv05 jr14335]$ llc fortran-contained-proc.ll -filetype=obj
  [cchen15 at f90srv05 jr14335]$ link -out:a.out -debug -pdb:a.pdb -subsystem:console fortran-contained-proc.obj
  Microsoft (R) Incremental Linker Version 14.29.30133.0
  Copyright (C) Microsoft Corporation.  All rights reserved.
  
  libcmt.lib(commit_mode.obj) : fatal error LNK1318: Unexpected PDB error; OK (0) ''

My very uneducated guess is that the new versions of linker tries to disallow a S_GPROC32_ID to have a type of LF_STRING_ID, but it's not done properly, resulting in this 'unexpected PDB error' as opposed to a more helpful diagnostic.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113142/new/

https://reviews.llvm.org/D113142