[PATCH] D113142: [CodeView] Properly handle a DISubprogram in getScopeIndex.

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

> Please note that before this patch, getScopeIndex would emit a LF_STRING_ID when given a DISubprogram. That's not only incorrect, but would also cause link-time error with the linker from a more recent version (Aug. 20219) of VS2019.

Really? It's what we do for C++ namespaces, though, right? I can't imagine why that would result in linker errors. Anyway, it's not important, I trust the new behavior is correct.



================
Comment at: llvm/test/DebugInfo/COFF/fortran-contained-proc.ll:25
+;
+; CHECK: S_GPROC32_ID [size = {{.*}}] `IF_TEST`
+; CHECK-NEXT: parent
----------------
I think the test should look at IF_TEST_ip_SUB, since that's the nested routine, not the main routine.  The nested routine should use the main routine as its parent scope, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113142/new/

https://reviews.llvm.org/D113142