[PATCH] D112860: [X86] Fix X32 indirect call generation

Harald van Dijk via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 3 11:42:23 PDT 2021


hvdijk added inline comments.


================
Comment at: llvm/test/CodeGen/X86/call-structfp.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -mtriple=x86_64-unknown-linux-gnux32 | FileCheck %s
----------------
MaskRay wrote:
> hvdijk wrote:
> > MaskRay wrote:
> > > Consider moving this into `x32-function_pointer-*.ll`
> > Sure. This comment was after the push, so it'd have to be a new separate change, but I could rename the test to `x32-function_pointer-4.ll` and add a `-fast-isel` `RUN` line like the other `x32-function_pointer-*.ll` tests if you like.
> (When I pushed the comment with "Accept", the revision had been closed.)
> 
> May not need a separate file. May just place several cases into one file. It is sometimes easier for readers to follow when placed in one file testing multiple variants.
`x32-function_pointer-3.ll` is closest to what's tested here since it also involves a function pointer in a struct, so it could be made part of that. I have no strong opinions on whether it should be, but no problem with it. However, that test was not created using `update_llc_test_checks.py`, and this one is, so one or the other would have to change if they were to be in the same file. This is not difficult, but also not trivial, it requires a little bit of consideration to figure out which way works best; I will take a look at that later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112860/new/

https://reviews.llvm.org/D112860



More information about the llvm-commits mailing list