[PATCH] D112860: [X86] Fix X32 indirect call generation

Wed Nov 3 10:23:42 PDT 2021

MaskRay added inline comments.

================
Comment at: llvm/test/CodeGen/X86/call-structfp.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -mtriple=x86_64-unknown-linux-gnux32 | FileCheck %s
----------------
hvdijk wrote:
> MaskRay wrote:
> > Consider moving this into `x32-function_pointer-*.ll`
> Sure. This comment was after the push, so it'd have to be a new separate change, but I could rename the test to `x32-function_pointer-4.ll` and add a `-fast-isel` `RUN` line like the other `x32-function_pointer-*.ll` tests if you like.
(When I pushed the comment with "Accept", the revision had been closed.)

May not need a separate file. May just place several cases into one file. It is sometimes easier for readers to follow when placed in one file testing multiple variants.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112860/new/

https://reviews.llvm.org/D112860