[PATCH] D112946: Remove builder that takes SSA value instead of Attribute on ExtractValueOp, InsetValueOp, and InsertOnRangeOp

Wed Nov 3 10:13:46 PDT 2021

mehdi_amini added a comment.

In D112946#3105442 <https://reviews.llvm.org/D112946#3105442>, @clementval wrote:

> In D112946#3104478 <https://reviews.llvm.org/D112946#3104478>, @mehdi_amini wrote:
>
>> In D112946#3102451 <https://reviews.llvm.org/D112946#3102451>, @clementval wrote:
>>
>>> This looks ok to me.
>>
>> Great, I assume I can land this then!
>
> I was still checking the repercussion of this on the code that still need to be upstreamed. Next time please wait for the formal approval.

Ah sorry about that! Feel free to revert if there are deeper issues with the direction.

In general I was expecting you to keep this kind of code in your fork as needed to ease the update.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112946/new/

https://reviews.llvm.org/D112946