[PATCH] D112946: Remove builder that takes SSA value instead of Attribute on ExtractValueOp, InsetValueOp, and InsertOnRangeOp

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 3 02:19:48 PDT 2021


clementval added a comment.

In D112946#3104478 <https://reviews.llvm.org/D112946#3104478>, @mehdi_amini wrote:

> In D112946#3102451 <https://reviews.llvm.org/D112946#3102451>, @clementval wrote:
>
>> This looks ok to me.
>
> Great, I assume I can land this then!

I was still checking the repercussion of this on the code that still need to be upstreamed. Next time please wait for the formal approval.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112946/new/

https://reviews.llvm.org/D112946



More information about the llvm-commits mailing list