[PATCH] D113070: [lld-macho] Silently ignore the -objc_abi_version
Jez Ng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 3 08:20:12 PDT 2021
int3 added a comment.
Oh, I remember what that test was checking for now... it was just there to make sure that any unimplemented flags were still being parsed correctly, regardless of whether we were emitting diagnostic warnings/errors for them. (Our Options.td initially had a bunch of flags expecting wrong numbers of arguments, which messed up the parsing of all the other flags even when they were ignored. That's the error condition that the `--not-an-ignored-argument` run command is checking for.)
I think for this diff, we can add another RUN command to the silent-ignore.test, but this time specifically checking that we don't emit any diagnostics for `-objc_abi_version`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113070/new/
https://reviews.llvm.org/D113070
More information about the llvm-commits
mailing list