[PATCH] D113070: [lld-macho] Silently ignore the -objc_abi_version

Keith Smiley via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 2 21:14:33 PDT 2021


keith added a comment.

In D113070#3104810 <https://reviews.llvm.org/D113070#3104810>, @int3 wrote:

> I like this, but let's see if anyone else chimes in over the next few days. I agree that we should add it to `silent-ignore.test` though.

I just took a list at this test, it seems like it's a bit invalid today. It looks like `--version` short circuits too early and the invalid flags aren't a problem in that case. `-objc_abi_version` is actually already in there. Am I reading the recommendation right there? I can update it to actually try to link a file so it gets far enough to error if that's the intent?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113070/new/

https://reviews.llvm.org/D113070



More information about the llvm-commits mailing list