[PATCH] D113090: [flang][CodeGen] Transform `fir.{store|load}` to `llvm.{store|load}`

Wed Nov 3 04:02:01 PDT 2021

clementval added a comment.

In D113090#3105615 <https://reviews.llvm.org/D113090#3105615>, @kiranchandramohan wrote:

> In D113090#3105389 <https://reviews.llvm.org/D113090#3105389>, @clementval wrote:
>
>> In D113090#3105376 <https://reviews.llvm.org/D113090#3105376>, @awarzynski wrote:
>>
>>> I wanted to add a test for `fir.ref<fir.box>`, but that does not work yet (it works fine on `fir-dev`). I wasn't sure why, so my comment in "flang/test/Fir/convert-to-llvm.fir" is a bit generic. Any pointers? Thanks!
>>
>> Not all of the type conversions have been upstreamed. I usually upstream the one I need with the op conversion I'm upstreaming.
>>
>> `flang/lib/Optimizer/CodeGen/TypeConverter.h`
>
> So does @awarzynski have to bring in the `convertBoxType` function?

Or it will come with D112961 <https://reviews.llvm.org/D112961> if anyone review it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113090/new/

https://reviews.llvm.org/D113090