[PATCH] D113090: [flang][CodeGen] Transform `fir.{store|load}` to `llvm.{store|load}`

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan added a comment.

In D113090#3105389 <https://reviews.llvm.org/D113090#3105389>, @clementval wrote:

> In D113090#3105376 <https://reviews.llvm.org/D113090#3105376>, @awarzynski wrote:
>
>> I wanted to add a test for `fir.ref<fir.box>`, but that does not work yet (it works fine on `fir-dev`). I wasn't sure why, so my comment in "flang/test/Fir/convert-to-llvm.fir" is a bit generic. Any pointers? Thanks!
>
> Not all of the type conversions have been upstreamed. I usually upstream the one I need with the op conversion I'm upstreaming.
>
> `flang/lib/Optimizer/CodeGen/TypeConverter.h`

So does @awarzynski have to bring in the `convertBoxType` function?



================
Comment at: flang/test/Fir/convert-to-llvm.fir:153
+
+// CHECK:  llvm.func @test_store() {
+// CHECK-NEXT:    llvm.store
----------------
missed the parameters.
Would it be good to match the parameters and the store operands?


================
Comment at: flang/test/Fir/convert-to-llvm.fir:174
+
+// CHECK:  llvm.func @test_load() {
+// CHECK-NEXT:    %{{.*}} = llvm.load
----------------
missed the parameters.
Would it be good to match the parameters and the load operands?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113090/new/

https://reviews.llvm.org/D113090