[PATCH] D113040: [lld-macho] Change bitfield types to be identical.

Tue Nov 2 13:43:50 PDT 2021

oontvoo added a comment.

In D113040#3104059 <https://reviews.llvm.org/D113040#3104059>, @thakis wrote:

> Bitfields can't be merged across classes in either abi: https://gcc.godbolt.org/z/n5Efxh551
>
> Also, `Defined` doesn't have a `refState` field.
>
> These fields are semantically bool, so I'd keep them that unless there's a reason to change it. In this case this doesn't buy anything as far as I can tell. (But if you have eg `/usr/bin/time -f  %M` / `/usr/bin/time -l` numbers to back up a benefit, then changes like this are great of course.)

oops ... too late . will revert it.

re: benefit: nothing measured yet , I'd been seeing a few warnings in the vicinity `warning: ‘lld::macho::DylibSymbol::refState’ is too small to hold all values of ‘enum class lld::macho::RefState’` so I started poking around an noticed this ...

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113040/new/

https://reviews.llvm.org/D113040