[PATCH] D113040: [lld-macho] Change bitfield types to be identical.
Nico Weber via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 2 13:38:47 PDT 2021
thakis added a comment.
Bitfields can't be merged across classes in either abi: https://gcc.godbolt.org/z/n5Efxh551
Also, `Defined` doesn't have a `refState` field.
These fields are semantically bool, so I'd keep them that unless there's a reason to change it. In this case this doesn't buy anything as far as I can tell. (But if you have eg `/usr/bin/time -f %M` / `/usr/bin/time -l` numbers to back up a benefit, then changes like this are great of course.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113040/new/
https://reviews.llvm.org/D113040
More information about the llvm-commits
mailing list