[PATCH] D112952: [AIX] Avoid depending on objdump

[Jinsong Ji via Phabricator via llvm-commits]

jsji updated this revision to Diff 384166.
jsji added a comment.

Address comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112952/new/

https://reviews.llvm.org/D112952

Files:
  llvm/utils/extract_symbols.py


Index: llvm/utils/extract_symbols.py
===================================================================
--- llvm/utils/extract_symbols.py
+++ llvm/utils/extract_symbols.py
@@ -126,6 +126,11 @@
             return (match.group(1) == 'COFF-i386')
     return False
 
+# On AIX, there isn't an easy way to detect 32-bit windows objects with the system toolchain,
+# so just assume false.
+def aix_is_32bit_windows(lib):
+    return False
+
 # MSVC mangles names to ?<identifier_mangling>@<type_mangling>. By examining the
 # identifier/type mangling we can decide which symbols could possibly be
 # required and which we can discard.
@@ -357,7 +362,7 @@
               'objdump' : (None, objdump_is_32bit_windows),
               'llvm-readobj' : (readobj_get_symbols, readobj_is_32bit_windows) }
     get_symbols = None
-    is_32bit_windows = None
+    is_32bit_windows = aix_is_32bit_windows if sys.platform.startswith('aix') else None
     # If we have a tools argument then use that for the list of tools to check
     if args.tools:
         tool_exes = args.tools


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D112952.384166.patch
Type: text/x-patch
Size: 1069 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211102/01ec5eac/attachment.bin>