[PATCH] D112952: [AIX] Avoid depending on objdump
David Tenty via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 1 20:29:23 PDT 2021
daltenty added inline comments.
================
Comment at: llvm/utils/extract_symbols.py:129-130
+# If we are relying on nm, then we are not targeting windows,
+# always return false.
+def aix_nm_is_32bit_windows(lib):
----------------
This isn't really related to us using nm. Technically someone could target 32-bit windows from AIX using the GNU toolchain, though no one is actually going to do that, so let's clarify what we're doing is working around limitations of the system toolchain.
================
Comment at: llvm/utils/extract_symbols.py:131
+# always return false.
+def aix_nm_is_32bit_windows(lib):
+ return False
----------------
================
Comment at: llvm/utils/extract_symbols.py:365
get_symbols = None
is_32bit_windows = None
# If we have a tools argument then use that for the list of tools to check
----------------
maybe let's just provide a default value before the search for AIX, rather than modifying the nm entry
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112952/new/
https://reviews.llvm.org/D112952
More information about the llvm-commits
mailing list