[PATCH] D113021: [cmake] Make LLVM_ENABLE_LLD=ON work better on macOS

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 2 10:33:46 PDT 2021


thakis added inline comments.


================
Comment at: llvm/cmake/modules/AddLLVM.cmake:196
       message(STATUS "Linker detection: ld64")
+    elseif("${stderr}" MATCHES "^LLD" OR
+           "${stdout}" MATCHES "^LLD")
----------------
hans wrote:
> isn't it enough to check one stream?
Yes, but lld currently writes it to stdout – but since ld64 writes to stderr that's an lld bug that we should fix (in D113020 :) ) so then this needs to support both behaviors, at least for a while.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113021/new/

https://reviews.llvm.org/D113021



More information about the llvm-commits mailing list