[PATCH] D113021: [cmake] Make LLVM_ENABLE_LLD=ON work better on macOS

[Hans Wennborg via Phabricator via llvm-commits]

hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.

lgtm with one question



================
Comment at: llvm/cmake/modules/AddLLVM.cmake:170
+if (NOT DEFINED LLVM_LINKER_DETECTED AND NOT WIN32)
+  # Detect what linker we have here
+  if(APPLE)
----------------
nit: maybe add a period while here.


================
Comment at: llvm/cmake/modules/AddLLVM.cmake:179
+
+  if( LLVM_USE_LINKER )
+    set(command ${CMAKE_C_COMPILER} -fuse-ld=${LLVM_USE_LINKER} ${version_flag})
----------------
nit: maybe drop the spaces while here.


================
Comment at: llvm/cmake/modules/AddLLVM.cmake:196
       message(STATUS "Linker detection: ld64")
+    elseif("${stderr}" MATCHES "^LLD" OR
+           "${stdout}" MATCHES "^LLD")
----------------
isn't it enough to check one stream?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113021/new/

https://reviews.llvm.org/D113021