[PATCH] D112946: Remove builder that takes SSA value instead of Attribute on ExtractValueOp, InsetValueOp, and InsertOnRangeOp

Eric Schweitz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 2 09:30:10 PDT 2021


schweitz added a comment.

In D112946#3101053 <https://reviews.llvm.org/D112946#3101053>, @clementval wrote:

> In D112946#3101041 <https://reviews.llvm.org/D112946#3101041>, @mehdi_amini wrote:
>
>> In D112946#3101033 <https://reviews.llvm.org/D112946#3101033>, @clementval wrote:
>>
>>> The pre-merge checks are failing during the build. Looks like there is a use of the builder somewhere.
>>
>> Indeed it was passing before I removed the declaration, which I think shows that this is dead code, but transitively speaking!
>
> This is probably left over from the version of the op that had values instead of attributes.

The code in the lowering directories is very out of date.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112946/new/

https://reviews.llvm.org/D112946



More information about the llvm-commits mailing list