[PATCH] D112946: Remove builder that takes SSA value instead of Attribute on ExtractValueOp, InsetValueOp, and InsertOnRangeOp

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 2 03:32:47 PDT 2021


clementval added a comment.

This looks ok to me. This will need some work downstream since the old build functions is used in couple of places with `fir::FieldIndexOp` and it is handy to extract the two coordinates attributes from the op and append them as attribute. But I guess we can refactor that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112946/new/

https://reviews.llvm.org/D112946



More information about the llvm-commits mailing list