[PATCH] D112899: Update fir.insert_on_range syntax to make the range more explicit (NFC)

Tue Nov 2 04:21:25 PDT 2021

kiranchandramohan accepted this revision.
kiranchandramohan added a comment.
This revision is now accepted and ready to land.

LGTM. Looks like a good syntax improvement.  Also seems to match the example given in  https://github.com/llvm/llvm-project/blob/bcad20bc6591c8b503923402038c735a77373f99/flang/include/flang/Optimizer/Dialect/FIROps.td#L2003.

I have a Nit suggestion.

Please wait for @clementval/@schweitz.

================
Comment at: flang/lib/Optimizer/Dialect/FIROps.cpp:1400
+      parser.parseCommaSeparatedList(
+          AsmParser::Delimiter::Square,
+          [&] { return parser.parseInteger(lbounds.emplace_back(0)); }) ||
----------------
Nit: The fortran array syntax uses `Paren`. Might be good to use that. Not a strong opinion. You can wait for other's comments.
i.e Fortran syntax is a(1,3) and not a[1,3].

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112899/new/

https://reviews.llvm.org/D112899