[PATCH] D112899: Update fir.insert_on_range syntax to make the range more explicit (NFC)

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 1 22:01:45 PDT 2021


mehdi_amini marked 2 inline comments as done.
mehdi_amini added inline comments.


================
Comment at: flang/lib/Optimizer/Dialect/FIROps.cpp:1464
+  printer << "from [";
+  StringRef comma = "";
+  // Even entries are the lower bounds.
----------------
kiranchandramohan wrote:
> Did you miss the comma here? 
> There might be a missing multi-coordinate test.
Thanks, good catch :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112899/new/

https://reviews.llvm.org/D112899



More information about the llvm-commits mailing list