[PATCH] D112940: Add a tool for diffing instruction count + stack size remarks

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 2 01:25:03 PDT 2021


jhenderson added a comment.

I've not looked into this patch at all, but my Herald rule got triggered, as I'm subscribed to llvm-size changes. That made me think it would be good if we could pick a different name that isn't going to have a prefix clash with other tools? This will help with some shells auto-completion, if nothing else! I don't have any concrete suggestions, but perhaps `llvm-remarks-diff` or something like that?



================
Comment at: llvm/test/tools/llvm-size-diff/no-instruction-count-remarks.test:4
+; CHECK: error: File {{.*}} did not contain any instruction-count remarks!
\ No newline at end of file

----------------
Nit: no new line at EOF


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112940/new/

https://reviews.llvm.org/D112940



More information about the llvm-commits mailing list