[PATCH] D112940: Add a tool for diffing instruction count + stack size remarks

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 1 18:46:31 PDT 2021


thegameg added a comment.

This is great, thanks! In general everything looks pretty good to me. I'll take a second look while others get some time to comment too!



================
Comment at: llvm/tools/llvm-size-diff/SizeDiff.cpp:299
+  auto Format =
+      remarks::parseFormat(ParserFormat == bitstream ? "bitstream" : "yaml");
+  if (!Format)
----------------
you can probably use `remarks::Format::YAML` and `remarks::Format::Bitstream` directly here


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112940/new/

https://reviews.llvm.org/D112940



More information about the llvm-commits mailing list