[PATCH] D112952: [AIX] Avoid depending on objdump

[Jinsong Ji via Phabricator via llvm-commits]

jsji updated this revision to Diff 383944.
jsji added a comment.

Address comment, support non AIX for nm.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112952/new/

https://reviews.llvm.org/D112952

Files:
  llvm/utils/extract_symbols.py


Index: llvm/utils/extract_symbols.py
===================================================================
--- llvm/utils/extract_symbols.py
+++ llvm/utils/extract_symbols.py
@@ -126,6 +126,13 @@
             return (match.group(1) == 'COFF-i386')
     return False
 
+# If we are relying on nm, then we are not targeting windows,
+# always return false.
+def nm_is_32bit_windows(lib):
+    if sys.platform.startswith('aix'):
+       return False
+    return None
+
 # MSVC mangles names to ?<identifier_mangling>@<type_mangling>. By examining the
 # identifier/type mangling we can decide which symbols could possibly be
 # required and which we can discard.
@@ -353,7 +360,7 @@
     # Determine the function to use to get the list of symbols from the inputs,
     # and the function to use to determine if the target is 32-bit windows.
     tools = { 'dumpbin' : (dumpbin_get_symbols, dumpbin_is_32bit_windows),
-              'nm' : (nm_get_symbols, None),
+              'nm' : (nm_get_symbols, nm_is_32bit_windows),
               'objdump' : (None, objdump_is_32bit_windows),
               'llvm-readobj' : (readobj_get_symbols, readobj_is_32bit_windows) }
     get_symbols = None


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D112952.383944.patch
Type: text/x-patch
Size: 1186 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211102/11e99764/attachment.bin>