[PATCH] D112952: [AIX] Avoid depending on objdump

David Tenty via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 1 16:25:19 PDT 2021


daltenty requested changes to this revision.
daltenty added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/utils/extract_symbols.py:131
+# always return false.
+def nm_is_32bit_windows(lib):
+    return False
----------------
Won't this break other platforms?  This script could (and probably is) run on Windows with GNU toolchain (i.e. MINGW with GNU nm) and would fall in to this case and get incorrect results


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112952/new/

https://reviews.llvm.org/D112952



More information about the llvm-commits mailing list