[PATCH] D112899: Update fir.insert_on_range syntax to make the range more explicit (NFC)

Kiran Chandramohan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 1 02:46:45 PDT 2021


kiranchandramohan added inline comments.


================
Comment at: flang/lib/Optimizer/Dialect/FIROps.cpp:1477-1483
+// void fir::InsertOnRangeOp::build(mlir::OpBuilder &builder,
+//                                  OperationState &result, mlir::Type resTy,
+//                                  mlir::Value aggVal, mlir::Value eleVal,
+//                                  llvm::ArrayRef<mlir::Value> inds) {
+//   auto aa = collectAsAttributes<false>(builder.getContext(), result, inds);
+//   build(builder, result, resTy, aggVal, eleVal, aa);
+// }
----------------
Remove commented code?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112899/new/

https://reviews.llvm.org/D112899



More information about the llvm-commits mailing list